fix: add --db-workspace-update-propagation-delay CLI flag #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When some configuration is applied to a non-existent workspace, decK creates the workspace before proceeding with the other queries. In such cases, it may happen that Kong is not "fast" enough to propagate workspace changes, leading to some misleading 404s due to not-existing (not-propagated) workspaces. This commit is adding a new --db-workspace-update-propagation-delay CLI flag to introduce an artificial delay when a new workspace is created. This is different from the --db-update-propagation-delay flag, as the latter gets applied to every insert operation and it was initially introduced to address some Cassandra limitation.
aboudreault
reviewed
Nov 8, 2022
| @@ -206,6 +207,8 @@ func syncMain(ctx context.Context, filenames []string, dry bool, parallelism, | |||
| if err != nil { | |||
| return err | |||
| } | |||
| // make sure the DB is updated and ready to receive new workspace queries. | |||
| time.Sleep(time.Duration(syncCmdDBWSUpdateDelay) * time.Second) | |||
There was a problem hiding this comment.
there is no workspace endpoint we could query in a waiting mode for this issue?
There was a problem hiding this comment.
very good point! We can probably wait for a 200 on /workspaces/<ws> or something like that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When some configuration is applied to a non-existent workspace, decK creates the workspace before proceeding with the other queries. In such cases, it may happen that Kong is not "fast" enough to propagate workspace changes, leading to some misleading 404s due to not-existing (not-propagated) workspaces.
This commit is adding a new --db-workspace-update-propagation-delay CLI flag to introduce an artificial delay when a new workspace is created.
This is different from the --db-update-propagation-delay flag, as the latter gets applied to every insert operation and it was initially introduced to address some Cassandra limitation.
Related to #783