add ability to override pgo path #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
reviewed
Jun 20, 2025
Owner
Kobzol
left a comment
Kobzol
left a comment
There was a problem hiding this comment.
Thank you! One nit, otherwise looks good.
Contributor
Author
|
Oops, I forgot to fix the test 😓 |
auto-merge was automatically disabled
June 23, 2025 13:06
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
June 24, 2025 04:59
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
June 26, 2025 02:25
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds the ability to override where the PGO directory is set.
Closes: #74