Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings due to improper exclusion; update gitignore #71

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

Joebayld
Copy link
Contributor

Fix warnings due to improper exclusion in Package.swift file.

Same fixes as in Kitura/BlueSocket#206

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2021

CLA assistant check
All committers have signed the CLA.

@Joebayld
Copy link
Contributor Author

Closes #70

@dannys42
Copy link
Contributor

@Joebayld Thanks for making this PR. FYI, I have to update the CI rules before I can merge this.

@dannys42
Copy link
Contributor

See PR -72 if you want to follow the CI changes.

@Joebayld
Copy link
Contributor Author

Do I need to do anything regarding the CI changes?

@remuslazar
Copy link

@dannys42 could u please provide an update on this one? The Xcode warnings are quite annoying..

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dannys42
Copy link
Contributor

dannys42 commented Oct 20, 2021

Sorry for the delay. I'll try to get the version update in later today.

@dannys42 dannys42 merged commit b8c3255 into Kitura:master Oct 20, 2021
@omochi
Copy link

omochi commented Oct 22, 2021

Thank you. I was waiting it!

@dannys42
Copy link
Contributor

You're welcome. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants