Add error card when generated model is empty #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
franknoirot
added
bug
franknoirot
changed the title
Irev-Dev
approved these changes
Jan 10, 2024
|
so technically these shouldnt reach the ui and should have already thrown an error but this is good just in case, but i really wanna know if any leak thru, but new api changes are deployed |
|
Yeah is there a way for me to log loudly when this card appears? I can do it pretty easily from the component but I'm not sure the best place to log to |
|
Could send it to sentry? But no worries this is good for all previous models to my patch too and if we logged those it would be noisy |
|
Ah right wouldn't want to log every time it appeared in the UI that'd be way too much, makes sense. I'll keep an eye out though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presents the user with an error state if the successfully-generated model from a prompt turns out to be empty, as having an empty scene with successful UI was confusing and made it hard to tell if it was an issue with the camera or something else.
Demo
empty-scene-demo-compressed.mp4