Update setup.py #475
Closed
Update setup.py #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was trying to build wheel packages for different platform but the current setup.py gives me `snowboy-1.3.0-py3-none-any.whl` instead of `snowboy-1.3.0-cp36-cp36m-linux_x86_64.whl`. This commit will correct that. Reference taken from [Anthony Sottile from stackoverflow](https://stackoverflow.com/questions/45150304/how-to-force-a-python-wheel-to-be-platform-specific-when-building-it).
imrrahul
approved these changes
Mar 7, 2019
|
Closing this pull request since it has been inactive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hongquanand I was trying to build wheel packages for different platform but the current setup.py gives us
snowboy-1.3.0-py3-none-any.whlinstead ofsnowboy-1.3.0-cp36-cp36m-linux_x86_64.whl(on 64bit linux) orsnowboy-1.3.0-cp35-cp35m-linux_armv61.whl(on armv6)We're afraid that if we upload
snowboy-1.3.0-py3-none-any.whlthat is compiled using an x86_64 cpu, it will not be usable on an, for example, arm6 or arm7 cpu device (e.g. Raspberry Pi Zero, Pi 3B/3B+).Reference taken from Anthony Sottile from stackoverflow.