Skip to content

Commit

Permalink
fix: correctly get aps config for queued ad ids (#133)
Browse files Browse the repository at this point in the history
## Description

This PR fixes a bug where, for queued ad IDs in a scenario using APS,
the APS config was attempted to be read at `slots[id].gpt.aps` instead
of `slots[id].aps`, where it actually exists.

The impact is that Amazon TAM is not working for these queued ads. This
is currently affecting our website, so a review and merge would be
greatly appreciated :)
  • Loading branch information
bmaclachlan authored Feb 7, 2024
1 parent 05f2bb8 commit e377243
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Advertising.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export default class Advertising {
try {
window.apstag.fetchBids(
{
slots: selectedSlots.map((slot) => slot.aps),
slots: queue.map(({ id }) => slots[id].aps),
},
() => {
Advertising.queueForGPT(() => {
Expand Down

0 comments on commit e377243

Please sign in to comment.