spirv-val: Add Vulkan Aligned PowerOfTwo check #6027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-lunarg
force-pushed
the
spencer-lunarg-aligned-pot
branch
from
25fe4da to
19d9913
Compare
|
I think this should be safe for all APIs. OpenCL makes it undefined behaviour for unaligned loads and stores. |
spencer-lunarg
force-pushed
the
spencer-lunarg-aligned-pot
branch
from
19d9913 to
e0912c2
Compare
Yep, and the SPIR-V spec was updated and removed the Vulkan-only part |
alan-baker
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hit in KhronosGroup/Vulkan-ValidationLayers#9531 and creating spec VU in https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/7210
The
Alignedliteral value should be allowed to be things like0or3(related Glslang issue KhronosGroup/glslang#3893)