Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clients (game engines) to the matrix #44

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

BastiaanOlij
Copy link

@BastiaanOlij BastiaanOlij commented Sep 3, 2024

This PR adds game engines to our extension support matrix.

Currently only Godot's list of extensions has been completed, other engines added as placeholders.

image

Note, build on top of #31

@dennyronngren
Copy link
Contributor

dennyronngren commented Sep 4, 2024

I think that the section could change name to "OpenXR adoption matrix" or something similar as it's not just runtimes in it anymore.

I really like having the engines in there. If we get good coverage it would help for our internal runtime planning also.

@fire
Copy link

fire commented Sep 6, 2024

It would be encouraging to have a few more engine vendors to submit their adoption matrix.

@dsnopek
Copy link

dsnopek commented Sep 6, 2024

Are we limiting the list to extensions in stable versions?

If not, we also have XR_KHR_visibility_mask.

However, I could certainly understand only listing extensions supported in stable Godot versions. We could then update this matrix after each stable release.

@BastiaanOlij
Copy link
Author

It would be encouraging to have a few more engine vendors to submit their adoption matrix.

That in the end is up to them, same as with the maintenance of the list of runtimes.

I only added them as an example, before this gets merged we need to remove those for which we haven't received updated so the engine vendors can add their own PRs on top.

I have asked for participation and if I get a list of extensions for other engines, I'll be happy to include them in this PR.

@BastiaanOlij
Copy link
Author

Are we limiting the list to extensions in stable versions?

If not, we also have XR_KHR_visibility_mask.

However, I could certainly understand only listing extensions supported in stable Godot versions. We could then update this matrix after each stable release.

I think so.

@rpavlik should we add some sort of disclaimer on the page that states there is no guarantee this list is up to date or missing entries?

@BastiaanOlij
Copy link
Author

@rpavlik @dennyronngren I've rebased this on master and applied your suggestions both here and given elsewhere.

With the rebase this supersedes Denny's PR.

@BastiaanOlij BastiaanOlij force-pushed the add_clients branch 2 times, most recently from 6dfb523 to ba3364e Compare September 13, 2024 03:54
@BastiaanOlij
Copy link
Author

Rebased to include bytedance latest changes.

I don't know enough about the framework we're using for how this is styled but it would seem it would be a good idea to increase the width of the header to match the width of the matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants