Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uuid comparison. This is not in the spec #2288

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshqti
Copy link
Contributor

@joshqti joshqti commented Feb 20, 2025

Remove comparison of Vulkan and OpenCL UUID. This is not required by the specification for external import of images. I think we should consider defining this behavior in the spec to ensure portable application code.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@joshqti
Copy link
Contributor Author

joshqti commented Feb 25, 2025

Please test. This iterates over all physical devices, but I disabled everything except the image subtest.

- Iterates over all physical devices
- Use device local memory
- Remove excess logging so device selection is visible.
- Only run image test
@joshqti joshqti force-pushed the remove_uuid_comparison branch from ddddee3 to ac191d2 Compare February 27, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants