Refactor clCopyImage and clFillImage tests #2283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change refactors clFillImage tests to pass image memory flag rather than hard coding a single value. Signed-off-by: Michael Rizkalla <[email protected]>
This change refactors clCopyImage tests to pass in source and destination image type and memory flags. This enables us to run multiple tests configurations per image type. Signed-off-by: Michael Rizkalla <[email protected]>
MichaelRizkalla-arm
force-pushed
the
refactor_images_tests
branch
from
8f60cad to
2a6956e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change mainly extends
clFillImageandclCopyImagetest function to include memory flags to be used during creating the image instead of hard-coding these values. The memory flags are also different parameters for source and destination images inclCopyImagetests.