Vulkan multiimport diffctx fix #2273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjust multi import diff ctx subtest to mirror behaviour in multi import same ctx subtest by using the clExternalExportableSemaphore class for vkCL2VkSemaphore
adjust multi import diff ctx subtest to mirror behaviour in multi import same ctx subtest by using the clExternalExportableSemaphore class for vkCL2VkSemaphore
…into vulkan-multiimport-diffctx-fix
|
|
|
May be superseded by #2243 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multi import diff ctx portion of the Vulkan test mistakenly instantiates clExternalImportableSemaphore objects as wrappers for semaphores that will be exported (vkCl2VkSemaphore). This change corrects this and mirrors the correct behavior found in the multi import same ctx test.