Fix signalling and waiting on semaphore from two queues #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashbaug
reviewed
Feb 11, 2025
Comment on lines
274
to
275
| err = clFinish(producer_queue); | ||
| test_error(err, "clFinish failed"); |
There was a problem hiding this comment.
Would a clFlush be sufficient here, or does this need to be a clFinish?
I believe both are correct, but the test is a little stronger if it's a clFlush and not a clFinish. With a clFinish, the semaphore is a NOP for an implementation that maximally batches commands.
There was a problem hiding this comment.
I agree, flush is a bit more appropriate here.
There was a problem hiding this comment.
I've updated the commit to use clFlush
`semaphores_ooo_ops_cross_queue` uses two OOO command queues to run the test. In one queue, a semaphore is signalled and the semahpore is waited on in the other queue. The CL specification requires the application to synchronize the queues if objects are shared. Signed-off-by: Michael Rizkalla <[email protected]>
MichaelRizkalla-arm
force-pushed
the
fix_semaphore_ooo_queues_test
branch
from
f7a2b6a to
57edc75
Compare
|
Looks good for Qualcomm |
bashbaug
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
semaphores_ooo_ops_cross_queueuses two OOO command queues to run the test. In one queue, a semaphore is signalled and the semahpore is waited on in the other queue.The CL specification requires the application to synchronize the queues if objects are shared.