Refactor buffer ReadWrite and Copy tests #2259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakshmih
reviewed
Feb 12, 2025
| memset(invalid_ptr.get(), 0xdeaddead, | ||
| num_elements); // seed with incorrect data | ||
| memset(out_ptr.get(), 0xdeadbeef, | ||
| num_elements); // seed with incorrect data |
There was a problem hiding this comment.
This code only sets a quarter of the buffer, because memset only writes 1 byte, so the first quarter of invalid_ptr will be filled with 0xad and the rest will be unknown values.
So this would be better included in the for loop that is next:
for (int i = 0; i < num_elements; i++)
{
invalid_ptr[i] = (int)0xdeaddead;
out_ptr[i] = (int)0xdeadbeef;
reference_ptr[i] = (int)genrand_int32(d);
}
There was a problem hiding this comment.
Thanks for catching it.
I have updated the commit.
Allow bufferreadwriterect test to use a customisable read, write and copy test functions. Signed-off-by: Michael Rizkalla <[email protected]>
This change uses RAII to manage object lifetimes to ensure objects' destruction if an error occurred in the test. Additionally, modify `test_arrayreadwrite` to pass a custom memory flag to the test function. Signed-off-by: Michael Rizkalla <[email protected]>
MichaelRizkalla-arm
force-pushed
the
refactor_buffer_tests
branch
from
781890b to
e1b2cfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the following tests to use RAII to clean-up allocated resources on exit, and adds additional changes as mentioned below:
cl_mem_flagsto be passed to the test.cl_mem_flagsto be passed to the test.invalid_ptrinstead ofout_ptrif created withCL_MEM_(USE/COPY)_HOST_PTR.invalid_ptrinstead ofout_ptrif created withCL_MEM_(USE/COPY)_HOST_PTR.