Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added object comparability verification for default device queue #2171

Conversation

shajder
Copy link
Contributor

@shajder shajder commented Dec 6, 2024

Fixes #1485 according to work plan, point CL_QUEUE_DEVICE_DEFAULT

Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test needed? It looks like this scenario is already tested in api/test_device_command_queue.cpp. See: #1551

@shajder
Copy link
Contributor Author

shajder commented Feb 13, 2025

Is this test needed? It looks like this scenario is already tested in api/test_device_command_queue.cpp. See: #1551

Thanks for noticing that. It looks like an unfortunate coincidence. I posted my analysis (without answer) in october 2024 before first commit in #1551 and I created my PR before #1551 was merged. Pity.

@bashbaug
Copy link
Contributor

Should we just close this PR then?

@shajder
Copy link
Contributor Author

shajder commented Feb 14, 2025

Should we just close this PR then?

Yes

@shajder shajder closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add test for object comparability
3 participants