Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIPT (Just In Place Translation) fix up dependency types #879

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jeremywiebe
Copy link
Collaborator

Summary:

Our JIPT configuration on the dependencies required the full JIPT configuration even when JIPT support was disabled (useJIPT: false). I've changed it so the types don't require the extra support functions when JIPT is not enabled. This makes the code clearer where we support this feature and should make dependency setup in host apps clearer as well.

Issue: "none"

Test plan:

@jeremywiebe jeremywiebe self-assigned this Dec 18, 2023
Copy link
Contributor

github-actions bot commented Dec 18, 2023

Size Change: +55 B (+0.01%)

Total Size: 866 kB

Filename Size Change
packages/perseus/dist/es/index.js 417 kB +55 B (+0.01%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.8 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.8 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 283 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.54 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e9a74bf) 58.53% compared to head (242530d) 60.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
+ Coverage   58.53%   60.12%   +1.58%     
==========================================
  Files         406      408       +2     
  Lines       99384    99400      +16     
  Branches     5979     8577    +2598     
==========================================
+ Hits        58174    59763    +1589     
+ Misses      41210    39637    -1573     

Impacted file tree graph

Files Coverage Δ
...ackages/perseus/src/components/graphie-movables.ts 76.17% <75.00%> (+6.35%) ⬆️
packages/perseus/src/components/svg-image.tsx 68.04% <0.00%> (+6.03%) ⬆️
packages/perseus/src/renderer.tsx 92.61% <33.33%> (+0.05%) ⬆️

... and 68 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a74bf...242530d. Read the comment docs.

Copy link
Contributor

github-actions bot commented Nov 14, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (2a23f20) and published it to npm. You
can install it using the tag PR879.

Example:

yarn add @khanacademy/perseus@PR879

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR879

Comment on lines -474 to -476
graphieMovablesJiptLabels: JiptLabelStore;
svgImageJiptLabels: JiptLabelStore;
rendererTranslationComponents: JiptTranslationComponents;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These only make sense when useJIPT: true, so I've moved these into the JIPT type union when useJIPT: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant