-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the Shift functions Error by resolving a falsey bug with the Grapher Widget's asymptotes. #2336
Conversation
Size Change: +13 B (0%) Total Size: 734 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (52c22a3) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2336 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2336 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for pairing with me and getting us that last final step! So excited!
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Major Changes - [#2331](#2331) [`c2e33e522`](c2e33e5) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove CJS output from package (package is now ESM only) ### Patch Changes - Updated dependencies \[[`c2e33e522`](c2e33e5)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Major Changes - [#2331](#2331) [`c2e33e522`](c2e33e5) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove CJS output from package (package is now ESM only) ### Patch Changes - Updated dependencies \[[`c2e33e522`](c2e33e5)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Major Changes - [#2331](#2331) [`c2e33e522`](c2e33e5) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove CJS output from package (package is now ESM only) ### Patch Changes - Updated dependencies \[[`c2e33e522`](c2e33e5)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Major Changes - [#2331](#2331) [`c2e33e522`](c2e33e5) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove CJS output from package (package is now ESM only) ### Patch Changes - Updated dependencies \[[`c2e33e522`](c2e33e5)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Major Changes - [#2331](#2331) [`c2e33e522`](c2e33e5) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove CJS output from package (package is now ESM only) ### Patch Changes - [#2306](#2306) [`87b129dbf`](87b129d) Thanks [@tatianasnook](https://github.com/tatianasnook)! - Added the @typescript-eslint/strict-boolean-expressions rule to enforce explicit boolean expressions for numbers. Disabled strict-boolean-expressions errors using inline eslint-disable comments where the rule was triggered. - [#2323](#2323) [`745b6337c`](745b633) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Hide axis labels from screen readers - [#2336](#2336) [`3bfa609b9`](3bfa609) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Fix Grapher Widget so that static graphs without asymptotes load correctly. - Updated dependencies \[[`c2e33e522`](c2e33e5)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Major Changes - [#2331](#2331) [`c2e33e522`](c2e33e5) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove CJS output from package (package is now ESM only) ### Patch Changes - Updated dependencies \[[`c2e33e522`](c2e33e5)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Major Changes - [#2331](#2331) [`c2e33e522`](c2e33e5) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove CJS output from package (package is now ESM only) ### Patch Changes - Updated dependencies \[[`87b129dbf`](87b129d), [`745b6337c`](745b633), [`c2e33e522`](c2e33e5), [`3bfa609b9`](3bfa609)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Major Changes - [#2331](#2331) [`c2e33e522`](c2e33e5) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove CJS output from package (package is now ESM only) ### Patch Changes - Updated dependencies \[[`c2e33e522`](c2e33e5)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Major Changes - [#2331](#2331) [`c2e33e522`](c2e33e5) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove CJS output from package (package is now ESM only) ### Patch Changes - Updated dependencies \[[`c2e33e522`](c2e33e5)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Major Changes - [#2331](#2331) [`c2e33e522`](c2e33e5) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove CJS output from package (package is now ESM only) ## @khanacademy/[email protected] ### Major Changes - [#2331](#2331) [`c2e33e522`](c2e33e5) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove CJS output from package (package is now ESM only) ### Patch Changes - Updated dependencies \[[`c2e33e522`](c2e33e5)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Major Changes - [#2331](#2331) [`c2e33e522`](c2e33e5) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove CJS output from package (package is now ESM only) ### Patch Changes - Updated dependencies \[[`c2e33e522`](c2e33e5)]: - @khanacademy/[email protected] ## [email protected] ### Minor Changes - [#2327](#2327) [`7d1e7b0eb`](7d1e7b0) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Migrate Rollup to v4 ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`c2e33e522`](c2e33e5)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] Author: khan-actions-bot Reviewers: jeremywiebe Required Reviewers: Approved By: jeremywiebe Checks: ⏭️ 1 check has been skipped, ✅ 4 checks were successful Pull Request URL: #2335
Summary:
There's been a long standing bug regarding Graphers in hints, which has been making quite a bit of noise in our reports. (This bug has been causing nearly 70% of our rendering errors!)
After investigating with @Myranae, we discovered that the issue was stemming from a bug in the truthy logic when determining whether to render an asymptote. Normally, the asymptote property is null for graph types that do not require it. However, I believe that our
staticTransform
method may have been changing the asymptote to an empty array, which was resolving as "truthy".I've separated out this logic into a new property to properly handle this case. I've opted not to add new tests or to dig too much deeper into the
staticTransform
method as this was a time-boxed bugfix for a deprecated widget that is scheduled to be replaced with our Interactive Graph Widget in the near future.(PR completed with @Myranae)
Issue: LEMS-2717
Screenshot:
Test plan: