Allow itemDataVersion to be null when parsing Perseus assessment item JSON
#2321
+302
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion` to be null when parsing Perseus assessment item JSON
|
Size Change: +5 B (0%) Total Size: 736 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (6021d4b) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2321If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2321 |
Myranae
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Makes sense to me! If it can be undefined already, then allowing null also seems fine. I don't know the current uses for itemDataVersion, maybe some sort of upgrading? Would be nice to confirm any usages still work with null, but I don't think it would really be any different than undefined, so may not be necessary.
handeyeco
approved these changes
Mar 24, 2025
| @@ -0,0 +1,111 @@ | |||
| { | |||
| "question": { | |||
| "content": "\n [[☃ image 1]]\n\n##A shot after all\n\n*By Heather M. Meston*\n\n___\n\n1. I peered through the neglected bushes crowning the hill overlooking the field, a vicious debate raging in my mind.\n\n2. *To go or not to go?*\n\n3. *To try or not to try?*\n\n4. I winced as Marcus Fitzwilliam barreled into a blocking sled, 300 pounds of foam padding and metal. The sled flew back six feet.\n\n5. *I can’t compete with that,* I thought. I barely weighed a hundred pounds in snow boots. It would take a miracle for me to move that thing an inch.\n\n6. *Stop it, Jamila,* commanded my braver side. *You don’t need to be big to be a quarterback, just fast and smart. Marcus may be big, but his bad knee makes him slow.* My eyes drifted to a sleek form running sprints across the field. *Now, Hiro, on the other hand…he’s fast. Gotta watch out for him.*\n\n7. Before I could stop myself, I shoved through the bushes, my head held high even as my heart trembled.\n\n8. Donny, who’d lost two teeth playing last year, was the first to spy me. He completely missed the left-handed pass Raj sent his way, drawing Coach Franklin’s irritation. But before Coach could begin lecturing, Raj interrupted him to point out the intruder on the field.\n\n9. Me.\n\n10. Coach looked startled for a moment, then came to his senses. “Jamila! You looking for cheerleading tryouts? In the gym.”\n\n11. I thought of all the hours my brother Malik had spent practicing with me. I couldn’t disappoint him. “No, I’m here to try out. Er…that is…for football, I mean. For quarterback.” Smooth. So smooth.\n\n12. Raj laughed, Marcus grinned, and Coach’s mouth twisted like I'd just force-fed him a lemon \n\n13. “Well, you see,” he started, “It’s just that girls aren’t allowed on the football team. Too dangerous, you know.”\n\n14. *But it's not too dangerous for boys? What’s wrong with people?*\n\n15. “Actually, sir, that’s not true. There’s nothing saying we can’t play.” I pulled out my copy of the school handbook. “See?” I said. “The only qualifications are that a player must have at least a C average and that the coach and a doctor must declare the player physically fit. I have straight As, and here’s my doctor’s note.”\n\n16. He grimaced, and then his face lit up. “Well, I don’t declare you physically fit. So that’s that.” He folded his arms across his chest with a satisfied grin.\n\n17. “Why?” I asked.\n\n18. “Girls are too delicate for football. I don't care how good your brother was. You'll snap like a twig out there. Sorry.”\n\n19. I’d come prepared with a second printout. Silently, I handed the paper to Coach. It contained only 37 words.\n\n20. “What in the name of the [[☃ definition 1]] is this?” he asked.\n\n21. “A copy of Title 9, sir. It’s a policy stating that any school that receives money from the government–which ours does–can’t discriminate on the basis of gender. So, I think your reasoning might be invalid. Can we get on with tryouts now?”\n\n22. His face contorted with rage, then confusion, and finally resignation as he pointed towards the center line. “You wanna be quarterback? Show me you can get past these three–” he pointed to Marcus, Raj, and Hiro, “and get the ball to the end zone.” He tossed me a ball.\n\n23. I gulped. I’d expected we’d start slow, maybe with some sprints. \n\n24. *You’ve got this,* I coached myself as I walked toward the center line. *You’re ready. Even Malik said so.* \n\n25. When I arrived at the center line and saw the three boys between me and the end zone, a sense of calm settled over me. Strategy flooded my mind as I thought of everything I’d observed from the bushes. Marcus, on the right, was big but slow. Raj, in the center, had a tendency to cover the left side of his area. Hiro, on the left, was the biggest threat–he was fast and clever, and, as he smirked at me, I knew immediately what my best play would be.\n\n26. As Coach blew his whistle, I raced hard towards the left, ignoring the obvious opening on the right side of the field. No one who knew him ever tried to get past Hiro, so that’s exactly what I would do. I barely saw Hiro’s smirk change into a look of surprise as I approached him, sliding under his outstretched arms. I leapt into the end zone with a whoop of delight. \n\n27. Coach looked reluctantly impressed when I trotted back to him. “Well, that wasn’t half-bad. I think we might give you a shot after all.”\n\n[[☃ explanation 1]]\n\n\n=====", | |||
There was a problem hiding this comment.
I don't really love how much noise we get from using full content. It feels a little counter-productive because I'm not sure what parts of this are actually important to the PR. Maybe it'll make more sense when we start making changes to the snapshots, but right now it just feels like a distraction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There are a few content items that have
itemDataVersion: null, and these arecausing parser errors in production because the parser doesn't like
null.This PR updates the parser to accept
nullvalues foritemDataVersion.itemDataVersionis already marked deprecated, and can beundefined, so itseems harmless to allow
nullas well.Issue: none
Test plan:
pnpm test