[LEMS-2868] Answerless ServerItemRendererWithDebugUI #2289

handeyeco · 2025-03-07T17:03:40Z

Summary:

I wanted to be able to render/use widgets in Storybook, but have them rendered using answerless data rather than the full data.

Issue: LEMS-2868

…ionally render answerless data

github-actions · 2025-03-07T17:05:35Z

Size Change: 0 B

Total Size: 736 kB

ℹ️ View Unchanged

Filename	Size
`packages/kas/dist/es/index.js`	39.7 kB
`packages/keypad-context/dist/es/index.js`	760 B
`packages/kmath/dist/es/index.js`	11.1 kB
`packages/math-input/dist/es/index.js`	77.5 kB
`packages/math-input/dist/es/strings.js`	1.79 kB
`packages/perseus-core/dist/es/index.js`	32.2 kB
`packages/perseus-editor/dist/es/index.js`	136 kB
`packages/perseus-linter/dist/es/index.js`	22.8 kB
`packages/perseus-score/dist/es/index.js`	20.7 kB
`packages/perseus/dist/es/index.js`	370 kB
`packages/perseus/dist/es/strings.js`	6.74 kB
`packages/pure-markdown/dist/es/index.js`	4.14 kB
`packages/simple-markdown/dist/es/index.js`	13.1 kB

_{compressed-size-action}

github-actions · 2025-03-07T17:05:41Z

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (25d3d1f) and published it to npm. You
can install it using the tag PR2289.

Example:

pnpm add @khanacademy/perseus@PR2289

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2289

…ererWithDebugUI to optionally use answerless data for rendering

Myranae · 2025-03-17T21:57:44Z

packages/perseus/src/widgets/expression/expression.testdata.ts

 } from "@khanacademy/perseus-core";

 const createItemJson = (
    widgetOptions: PerseusExpressionWidgetOptions,
-    version: Version,


It seems like changing version to widgetVersion, adding extra keys, and modifying item 3 below is all that was done here. Did you add an item without answers somewhere? I think the big red and green chunks were just moved code, but I might have missed something.

jeremywiebe

This looks reasonable. One bit of feedback is that I'd suggest you revert the code moves unless there's a good reason as it'll make the PR clearer what's actually being changed.

jeremywiebe · 2025-03-18T20:07:46Z

packages/perseus/src/widgets/expression/expression.stories.tsx

@@ -122,6 +125,16 @@ export const ExpressionItem3 = (args: StoryArgs): React.ReactElement => {
    );
 };

+export const AnswerlessExpression = (args: StoryArgs): React.ReactElement => {


Where is this used? I don't see it referenced in this PR at all.

This is how Storybook works, by exporting the function in a .stories.tsx file it shows up in SB.

🤦‍♂️ I didn't take note this was in a .stories.tsx file!

jeremywiebe · 2025-03-18T20:11:28Z

packages/perseus/src/widgets/expression/expression.testdata.ts

 } from "@khanacademy/perseus-core";

 const createItemJson = (
    widgetOptions: PerseusExpressionWidgetOptions,
-    version: Version,
+    widgetVersion: Version = expressionLogic.version as Version,


Can we use satisfies instead of as here? Also, why do we need the cast at all? :)

expressionLogic is of type WidgetLogic and not all widgets have versions so version?: Version

You're right thought, it was overkill. It works with widgetVersion = expressionLogic.version

Myranae · 2025-03-19T19:41:35Z

I'm not sure this is working as we think it is. I could be missing something, but should the Perseus JSON section reflect the result of splitPerseusItem? In other words, should the answerful data be missing from the Perseus JSON area? In my testing, so far that's not the case. I assumed that was because we only need the render data to be missing the answers, but how do we confirm what data it's rendering with? I'm still testing since I'm working on this too, but curious if you have ideas or I missed something in regards to this.

UPDATE:
Okay, I think if the results of splitPerseusItem and this.props.widgets in the render method of renderer are the same, then we can confirm what is being rendered is what we want. Probably didn't need to dig in this far, but 🤷‍♀️ . Hopefully that's enough confirmation.

…werless-stories

@handeyeco

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`1b5f51415`](1b5f514), [`4c0b317c3`](4c0b317), [`335940746`](3359407)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`1b5f51415`](1b5f514), [`4c0b317c3`](4c0b317), [`335940746`](3359407)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`1b5f51415`](1b5f514), [`4c0b317c3`](4c0b317), [`335940746`](3359407)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#2289](#2289) [`87420d7d3`](87420d7) Thanks [@handeyeco](https://github.com/handeyeco)! - Update ServerItemRendererWithDebugUI to optionally use answerless data for rendering - [#2313](#2313) [`3b0b1c700`](3b0b1c7) Thanks [@nishasy](https://github.com/nishasy)! - [LX] Stop locked functions from memory leaking - Updated dependencies \[[`1b5f51415`](1b5f514), [`c170c1d3c`](c170c1d), [`4c0b317c3`](4c0b317), [`335940746`](3359407)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#2308](#2308) [`1b5f51415`](1b5f514) Thanks [@benchristel](https://github.com/benchristel)! - Fix a bug in numeric input scoring where `simplify` value of `false` led to incorrect scoring logic being applied - [#2319](#2319) [`4c0b317c3`](4c0b317) Thanks [@benchristel](https://github.com/benchristel)! - Internal: unskip regression tests for Perseus JSON parser and update snapshots - [#2272](#2272) [`335940746`](3359407) Thanks [@handeyeco](https://github.com/handeyeco)! - Add comments to external-facing functions ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`1b5f51415`](1b5f514), [`c170c1d3c`](c170c1d), [`87420d7d3`](87420d7), [`4c0b317c3`](4c0b317), [`335940746`](3359407), [`3b0b1c700`](3b0b1c7)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`1b5f51415`](1b5f514), [`4c0b317c3`](4c0b317), [`335940746`](3359407)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#2278](#2278) [`c170c1d3c`](c170c1d) Thanks [@handeyeco](https://github.com/handeyeco)! - Remove jQuery as a dependency of perseus-score - [#2272](#2272) [`335940746`](3359407) Thanks [@handeyeco](https://github.com/handeyeco)! - Add comments to external-facing functions - Updated dependencies \[[`1b5f51415`](1b5f514), [`4c0b317c3`](4c0b317), [`335940746`](3359407)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`1b5f51415`](1b5f514), [`4c0b317c3`](4c0b317), [`335940746`](3359407)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

[LEMS-2868/answerless-stories] make ServerItemRendererWithDebugUI opt…

4c3d5e1

…ionally render answerless data

handeyeco self-assigned this Mar 7, 2025

[LEMS-2868/answerless-stories] remove console.log

d9ff1b6

handeyeco changed the title ~~make ServerItemRendererWithDebugUI optionally render answerless data~~ [LEMS-2868] Answerless ServerItemRendererWithDebugUI Mar 7, 2025

[LEMS-2868/answerless-stories] docs(changeset): Update ServerItemRend…

0f0848b

…ererWithDebugUI to optionally use answerless data for rendering

handeyeco marked this pull request as ready for review March 7, 2025 18:10

handeyeco requested review from a team March 7, 2025 18:10

handeyeco added the 🐍 project: sss Server-Side Scoring ('24-'25) label Mar 11, 2025

Myranae reviewed Mar 17, 2025

View reviewed changes

jeremywiebe approved these changes Mar 18, 2025

View reviewed changes

handeyeco added 3 commits March 21, 2025 09:31

[LEMS-2868/answerless-stories] respond to Jeremy's feedback

da0f556

[LEMS-2868/answerless-stories] Merge branch 'main' into LEMS-2868/ans…

c41f9db

…werless-stories

[LEMS-2868/answerless-stories] use renderedItem in JSON preview

25d3d1f

handeyeco merged commit 87420d7 into main Mar 21, 2025
8 checks passed

handeyeco deleted the LEMS-2868/answerless-stories branch March 21, 2025 14:47

khan-actions-bot mentioned this pull request Mar 21, 2025

Version Packages #2320

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LEMS-2868] Answerless ServerItemRendererWithDebugUI #2289

[LEMS-2868] Answerless ServerItemRendererWithDebugUI #2289

handeyeco commented Mar 7, 2025 •

edited

Loading

github-actions bot commented Mar 7, 2025 •

edited

Loading

github-actions bot commented Mar 7, 2025 •

edited

Loading

Myranae Mar 17, 2025 •

edited

Loading

jeremywiebe left a comment

jeremywiebe Mar 18, 2025

handeyeco Mar 21, 2025 •

edited

Loading

jeremywiebe Mar 21, 2025

jeremywiebe Mar 18, 2025

handeyeco Mar 21, 2025

Myranae commented Mar 19, 2025 •

edited

Loading

[LEMS-2868] Answerless ServerItemRendererWithDebugUI #2289

[LEMS-2868] Answerless ServerItemRendererWithDebugUI #2289

Conversation

handeyeco commented Mar 7, 2025 • edited Loading

Summary:

github-actions bot commented Mar 7, 2025 • edited Loading

github-actions bot commented Mar 7, 2025 • edited Loading

npm Snapshot: Published

Myranae Mar 17, 2025 • edited Loading

Choose a reason for hiding this comment

jeremywiebe left a comment

Choose a reason for hiding this comment

jeremywiebe Mar 18, 2025

Choose a reason for hiding this comment

handeyeco Mar 21, 2025 • edited Loading

Choose a reason for hiding this comment

jeremywiebe Mar 21, 2025

Choose a reason for hiding this comment

jeremywiebe Mar 18, 2025

Choose a reason for hiding this comment

handeyeco Mar 21, 2025

Choose a reason for hiding this comment

Myranae commented Mar 19, 2025 • edited Loading

handeyeco commented Mar 7, 2025 •

edited

Loading

github-actions bot commented Mar 7, 2025 •

edited

Loading

github-actions bot commented Mar 7, 2025 •

edited

Loading

Myranae Mar 17, 2025 •

edited

Loading

handeyeco Mar 21, 2025 •

edited

Loading

Myranae commented Mar 19, 2025 •

edited

Loading