Skip to content

Commit

Permalink
Do a brew update, rather than brew install, if Go is already inst…
Browse files Browse the repository at this point in the history
…alled.

Summary: Either way, we try to pin them to go1.12, for consistency.

Test Plan: Fingers crossed! -- I don't have a mac

Reviewers: jvoll, benkraft, jacqueline

Reviewed By: jacqueline

Subscribers: jacqueline, samuel

Differential Revision: https://phabricator.khanacademy.org/D57298
  • Loading branch information
csilvers committed Aug 22, 2019
1 parent 105e8cd commit c18a522
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion mac-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,11 @@ install_node() {
install_go() {
if ! has_recent_go; then # has_recent_go is from shared-functions.sh
info "Installing go\n"
brew install [email protected]
if brew ls go >/dev/null 2>&1; then
brew upgrade [email protected]
else
brew install [email protected]
fi
else
success "go already installed"
fi
Expand Down

0 comments on commit c18a522

Please sign in to comment.