Skip to content

Commit

Permalink
[๐Ÿ”ฅAUDIT๐Ÿ”ฅ] Fix how we set JAVA_HOME in the PATH. (#111)
Browse files Browse the repository at this point in the history
๐Ÿ– _This is an audit!_ ๐Ÿ–

## Summary:
The old location didn't always work, apparently.

Issue: https://khanacademy.slack.com/archives/C04SEFXQBNU/p1709587347376909

## Test plan:
Fingers crossed

Author: csilvers

Auditors: #infra-platform

Required Reviewers:

Approved By:

Checks:

Pull Request URL: #111
  • Loading branch information
csilvers authored Mar 5, 2024
1 parent 4505d89 commit 78e39ce
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion shared-functions.sh
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ install_mac_java() {

# Ensure JAVA_HOME is set in ~/.profile.khan
# TODO (jwiesebron): Update other parts of dotfiles to use this convention
add_to_dotfile 'export JAVA_HOME=/Library/Java/JavaVirtualMachines/openjdk-11.jdk'
add_to_dotfile 'export JAVA_HOME="$(/usr/libexec/java_home)"'
add_to_dotfile 'export PATH="'"$brew_loc"/bin':$PATH"'
}

Expand Down

0 comments on commit 78e39ce

Please sign in to comment.