Skip to content

Commit

Permalink
update-os-output-mac (#119)
Browse files Browse the repository at this point in the history
Updates `mac-setup.sh` script print statement to output `This is tested on macOS 14 (Sonoma).` now that this script has executed successfully 3 times on computers running macOS 14 and using M3 chips (3 new engineers, including myself, who are onboarding for the TX team).

The script was able to run locally after the `echo` was updated.

Author: Bcdirito

Reviewers: Bcdirito, csilvers, MiguelCastillo

Required Reviewers:

Approved By: csilvers, MiguelCastillo

Checks:

Pull Request URL: #119
  • Loading branch information
Bcdirito authored Apr 26, 2024
1 parent 2642202 commit 3560359
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions mac-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ DEVTOOLS_DIR="$REPOS_DIR/devtools"
echo
echo "Running Khan Installation Script 1.2"

if ! sw_vers -productVersion 2>/dev/null | grep -q '10\.1[12345]\.' ; then
echo "This is tested on macOS 13 (Ventura)."
if ! sw_vers -productVersion 2>/dev/null | grep -q '^1[0-4]\.' ; then
echo "This is tested on macOS 14 (Sonoma)."
echo
echo "If you find that this works on a newer version of macOS, "
echo "please update this message."
echo "please update this message and the grep of this if statement."
echo
fi

Expand Down

0 comments on commit 3560359

Please sign in to comment.