Skip to content

Commit

Permalink
Update links from forge -> eng docs
Browse files Browse the repository at this point in the history
Summary: This commit updates any links in our setup script that used to go to Forge to their new eng doc pages (or in the case of our styleguides then to our Github repo).

Test Plan: Fingers crossed

Reviewers: benkraft, csilvers

Reviewed By: benkraft, csilvers

Subscribers: csilvers

Differential Revision: https://phabricator.khanacademy.org/D45306
  • Loading branch information
jacquelineawatts committed Jun 4, 2018
1 parent 49477f2 commit 0cfa0fb
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .vim/ftplugin/css.vim
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
" Khan Academy style guidelines: 4-space indents
" https://sites.google.com/a/khanacademy.org/forge/for-developers/styleguide/html-css-etc
" https://github.com/Khan/style-guides/blob/master/style/css.md
setlocal expandtab ts=4 sw=4 sts=4
2 changes: 1 addition & 1 deletion .vim/ftplugin/javascript.vim
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
" Khan Academy style guidelines: 4-space indents
" https://sites.google.com/a/khanacademy.org/forge/for-developers/styleguide/javascript
" https://github.com/Khan/style-guides/blob/master/style/javascript.md
setlocal expandtab sts=4 sw=4 ts=4
2 changes: 1 addition & 1 deletion .vim/ftplugin/less.vim
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
" Khan Academy style guidelines: 4-space indents
" https://sites.google.com/a/khanacademy.org/forge/for-developers/styleguide/html-css-etc
" https://github.com/Khan/style-guides/blob/master/style/css.md
setlocal expandtab ts=4 sw=4 sts=4
2 changes: 1 addition & 1 deletion .vim/ftplugin/python.vim
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
" Khan Academy style guidelines: 4-space indents
" https://sites.google.com/a/khanacademy.org/forge/for-developers/styleguide/python
" https://github.com/Khan/style-guides/blob/master/style/python.md
setlocal expandtab ts=4 sw=4 sts=4

" PEP-8 wants this (as does Khan linters)
Expand Down
2 changes: 1 addition & 1 deletion mac-android-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -146,4 +146,4 @@ install_watchman
install_react_native_dependencies

update "Done! Complete setup instructions at \
https://sites.google.com/a/khanacademy.org/forge/for-khan-employees/-new-employees-onboard-doc/developer-setup/mobile-setup/android-setup"
https://docs.google.com/document/d/1QMMgvycznCezczZojEdAk8WHm6oTDFwi6bEutYQJ40o"
2 changes: 1 addition & 1 deletion mac-ios-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,4 @@ install_watchman
install_react_native_dependencies

update "Done! Complete setup instructions at \
https://sites.google.com/a/khanacademy.org/forge/for-khan-employees/-new-employees-onboard-doc/developer-setup/mobile-setup/ios-setup"
https://docs.google.com/document/d/15FxEYI7l_p4mMv3SYFSIM6cxiOz6I4pxEvzDLFle-eE"
4 changes: 2 additions & 2 deletions setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ check_dependencies() {
# You need to have run the setup to install binaries: node, npm/etc.
if ! npm --version >/dev/null; then
echo "You must install binaries before running $0. See"
echo " https://sites.google.com/a/khanacademy.org/forge/for-khan-employees/-new-employees-onboard-doc/developer-setup"
echo " https://docs.google.com/document/d/1aD1K0t8BhJABMug14zFZE_Ea73am0EiU2szjcsILkiU"
exit 1
fi
}
Expand Down Expand Up @@ -234,7 +234,7 @@ install_deps() {
sudo easy_install --quiet pip

# Install virtualenv.
# https://sites.google.com/a/khanacademy.org/forge/for-khan-employees/-new-employees-onboard-doc/developer-setup/using-virtualenv
# https://docs.google.com/document/d/1zrmm6byPImfbt7wDyS8PpULwnEckSxna2jhSl38cWt8
sudo pip install -q virtualenv
if [ ! -d "$ROOT/.virtualenv/khan27" ]; then
# Note that --no-site-packages is the default on recent virtualenv,
Expand Down

0 comments on commit 0cfa0fb

Please sign in to comment.