Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38180 - Better names for flatpak rex templates #11297

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Jan 31, 2025

What are the changes introduced in this pull request?

Better names for flatpak templates to group them together.

Considerations taken when implementing this change?

As with other templates of similar grouping, use "Flatpak - " to create the grouping.

What are the testing steps for this pull request?

In rails console:
n Rails console: ForemanInternal.all.first.delete
Then run: bundle exec rails db:seed

In Jobs template list, check if the template names are updated and appear in order.

Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was annoying me 😅 thanks!

I still seem to have the old templates:
image

Could write some sort of migration to remove the old locked templates from the database. However, I don't think this will affect users, since it's a new feature. Thoughts?

@sjha4
Copy link
Member Author

sjha4 commented Jan 31, 2025

Ya..We don't need the migration outside of our dev boxes.. bundle exec rails db:reset..😄

@sjha4 sjha4 merged commit b959a02 into Katello:master Jan 31, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants