Fixes #38160 - Update hosts link to new hosts URL #11296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavanshekar
force-pushed
the
issue-38160
branch
from
0181057 to
77aefb2
Compare
jeremylenz
reviewed
Jan 30, 2025
Comment on lines
10
to
13
| const activationKeyCount = activationKeys.length; | ||
| const hostCount = hosts.length; | ||
| const uniqueActivationKeys = Array.from(new Map(activationKeys.map(activationKey => | ||
| [activationKey.id, activationKey])).values()); | ||
| const uniqueHosts = Array.from(new Map(hosts.map(host => [host.id, host])).values()); |
There was a problem hiding this comment.
Were there duplicate hosts or activation keys before? Where were they coming from?
There was a problem hiding this comment.
Due to multi-cv hosts and activation keys the hosts and activationKeys were giving duplicate entries.
pavanshekar
changed the title
pavanshekar
force-pushed
the
issue-38160
branch
2 times, most recently
from
2541cbb to
eb3a5f9
Compare
pavanshekar
force-pushed
the
issue-38160
branch
from
eb3a5f9 to
8307210
Compare
jeremylenz
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Updated the hosts link to use the new hosts URL instead of the old hardcoded UI link to dynamically determine the correct hosts page URL, improving maintainability and consistency.
Considerations taken when implementing this change?
The new hosts page URL was used to ensure consistency. Care was taken to maintain existing functionality while improving accuracy and maintainability.
What are the testing steps for this pull request?