Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38086 - Slow product last sync audit lookup #11294

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fixes #38086 - Slow product last sync audit lookup #11294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion app/models/katello/glue/pulp/repos.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,18 @@ def sync_summary
end

def last_sync_audit
Audited::Audit.where(:auditable_id => self.repositories, :auditable_type => Katello::Repository.name, :action => "sync").order(:created_at).last
repository_ids = self.repositories.pluck(:id)
return nil if repository_ids.blank?

Audited::Audit
.where(
auditable_id: repository_ids,
auditable_type: Katello::Repository.name,
action: "sync"
)
.order(created_at: :desc)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please post here an sql explain analyze of this both with and without the new index?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point..I tested this and the new index isn't being used for this query for my data setup..Trying to get some real data to test this since with my duplicated audit records, psql seems to not need indexing outside of created_at..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

katello=# EXPLAIN ANALYZE
katello-# SELECT "audits".* 
FROM "audits" 
WHERE "audits"."auditable_id" = 7 
AND "audits"."auditable_type" = 'Katello::Repository' 
AND "audits"."action" = 'sync' 
ORDER BY "audits"."created_at" DESC 
LIMIT 1;
                                                                                 QUERY PLAN                                                       
                           
--------------------------------------------------------------------------------------------------------------------------------------------------
---------------------------
 Limit  (cost=0.56..4.63 rows=1 width=2224) (actual time=0.016..0.016 rows=0 loops=1)
   ->  Index Scan using index_audits_on_auditable_type_id_action_created_at_desc on audits  (cost=0.56..244.88 rows=60 width=2224) (actual time=0.
016..0.016 rows=0 loops=1)
         Index Cond: (((auditable_type)::text = 'Katello::Repository'::text) AND (auditable_id = 7) AND ((action)::text = 'sync'::text))
 Planning Time: 0.091 ms
 Execution Time: 0.049 ms
(5 rows)

katello=# \d audits;
                                           Table "public.audits"
     Column      |            Type             | Collation | Nullable |              Default               
-----------------+-----------------------------+-----------+----------+------------------------------------
 id              | integer                     |           | not null | nextval('audits_id_seq'::regclass)
 auditable_id    | integer                     |           |          | 
 auditable_type  | character varying(255)      |           |          | 
 user_id         | integer                     |           |          | 
 user_type       | character varying(255)      |           |          | 
 username        | character varying(255)      |           |          | 
 action          | character varying(255)      |           |          | 
 audited_changes | text                        |           |          | 
 version         | integer                     |           |          | 0
 comment         | character varying(255)      |           |          | 
 associated_id   | integer                     |           |          | 
 associated_type | character varying(255)      |           |          | 
 request_uuid    | character varying(255)      |           |          | 
 created_at      | timestamp without time zone |           |          | 
 remote_address  | character varying(255)      |           |          | 
 auditable_name  | text                        |           |          | 
 associated_name | character varying(255)      |           |          | 
Indexes:
    "audits_pkey" PRIMARY KEY, btree (id)
    "index_audits_on_associated_type_and_associated_id" btree (associated_type, associated_id)
    "index_audits_on_auditable_type_and_auditable_id_and_version" btree (auditable_type, auditable_id, version)
    "index_audits_on_auditable_type_id_action_created_at_desc" btree (auditable_type, auditable_id, action, created_at DESC)
    "index_audits_on_created_at" btree (created_at)
    "index_audits_on_request_uuid" btree (request_uuid)
    "index_audits_on_user_type_and_user_id" btree (user_type, user_id)

katello=# DROP INDEX IF EXISTS index_audits_on_auditable_type_id_action_created_at_desc;
DROP INDEX
katello=# EXPLAIN ANALYZE
SELECT "audits".* 
FROM "audits" 
WHERE "audits"."auditable_id" = 7 
AND "audits"."auditable_type" = 'Katello::Repository' 
AND "audits"."action" = 'sync' 
ORDER BY "audits"."created_at" DESC 
LIMIT 1;
                                                                                   QUERY PLAN                                                     
                               
--------------------------------------------------------------------------------------------------------------------------------------------------
-------------------------------
 Limit  (cost=311.04..311.05 rows=1 width=2224) (actual time=1.924..1.925 rows=0 loops=1)
   ->  Sort  (cost=311.04..311.19 rows=60 width=2224) (actual time=1.924..1.924 rows=0 loops=1)
         Sort Key: created_at DESC
         Sort Method: quicksort  Memory: 25kB
         ->  Bitmap Heap Scan on audits  (cost=5.22..310.74 rows=60 width=2224) (actual time=1.920..1.920 rows=0 loops=1)
               Recheck Cond: (((auditable_type)::text = 'Katello::Repository'::text) AND (auditable_id = 7))
               Filter: ((action)::text = 'sync'::text)
               Rows Removed by Filter: 7
               Heap Blocks: exact=1
               ->  Bitmap Index Scan on index_audits_on_auditable_type_and_auditable_id_and_version  (cost=0.00..5.21 rows=78 width=0) (actual tim
e=1.914..1.915 rows=7 loops=1)
                     Index Cond: (((auditable_type)::text = 'Katello::Repository'::text) AND (auditable_id = 7))
 Planning Time: 0.178 ms
 Execution Time: 1.945 ms
(13 rows)

Screenshot from 2025-01-30 13-09-28

.limit(1)
.first
end

def last_sync
Expand Down
5 changes: 4 additions & 1 deletion ...ascripts/bastion_katello/products/details/repositories/details/views/repository-info.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,9 +396,12 @@ <h4 translate>Sync Status</h4>
<span ng-include="'products/details/partials/sync-status.html'"></span>

<dt translate>Last Sync</dt>
<dd ng-show="repository.last_sync == null" translate>
<dd ng-show="repository.last_sync == null && repository.last_sync_words == null" translate>
Not Synced
</dd>
<dd ng-show="repository.last_sync == null && repository.last_sync_words" translate>
Completed {{ repository.last_sync_words }} ago
</dd>
<dd ng-hide="repository.last_sync == null || repository.last_sync.ended_at == null">
<relative-date date="repository.last_sync.ended_at" />
(<short-date-time date="repository.last_sync.ended_at" /> <translate>Local Time</translate>)
Expand Down