Fixes #37033 - Drop unused katello:rubocop:jenkins rake task #10838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins uses katello:rubocop and doesn't parse the results right now, so the dependency can be dropped safely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
The task is dropped and the unused
rubocop-checkstyle_formatterdependency is removed.Considerations taken when implementing this change?
Jenkins uses katello:rubocop and doesn't parse the results right now, so the dependency can be dropped safely.
theforeman/jenkins-jobs#400 enables parsing of the results again, but these days the default formatter (progress) output can be parsed by Jenkins.
What are the testing steps for this pull request?
Verify CI still passes.