Add a data retention cron #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These weren't being cleaned up anywhere else.
TheJosh
reviewed
Aug 28, 2018
|
|
||
| // Ensure they haven't provided a negative interval as this will cause the | ||
| // threshold to move forward in time. | ||
| if ($job_spec['min_age']->invert) { |
There was a problem hiding this comment.
Instead of complaining, could we just toggle-off the invert flag?
| @@ -59,6 +59,20 @@ | |||
| Register::cronJob('daily', 'Sprout\\Controllers\\Admin\\FileAdminController', 'cronCleanupInvalid'); | |||
| Register::cronJob('daily', 'Sprout\\Controllers\\ContentSubscribeController', 'cronSendSubscriptions'); | |||
| Register::cronJob('daily', 'Sprout\\Controllers\\Admin\\ActionLogAdminController', 'cronCleanup'); | |||
| Register::cronJob('daily', 'Sprout\\Controllers\\RetentionCronController', 'cronRetention'); | |||
|
|
|||
| // Purge exception log entries after 14 days | |||
There was a problem hiding this comment.
These comments don't really add anything here, except maybe the fact that ISO 8601 period specs are a little opaque.
Of course we could switch away from ISO 8601 period specs and instead to strtotime relative time strings (e.g. '14 days')
|
|
||
| $threshold = clone $now; | ||
| $threshold->sub($job_spec['min_age']); | ||
| $threshold = $threshold->format('Y-m-d H:i:s'); |
There was a problem hiding this comment.
Should the comparison be made on the date portion only?
| Cron::message("Purging records from '{$job_spec['table']}' ({$job_spec['column']}) updated before {$threshold}"); | ||
|
|
||
| $conds = [ | ||
| [$job_spec['column'], '<', $threshold] |
There was a problem hiding this comment.
If there is an index on the column, will it be hit?
|
|
||
| $q = "DELETE FROM ~{$job_spec['table']} WHERE {$where}"; | ||
| $count = Pdb::q($q, $params, 'count'); | ||
|
|
There was a problem hiding this comment.
Should we run OPTIMIZE TABLE on MyISAM tables (either automatically or when set via an option flag)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a simple, data driven interface to purging old data from tables.
I've moved exception log and worker job clean-up into retention jobs, which in the former case avoids a potentially lengthy operation (delete on MyIASM tables grows increasingly slow the more operations performed sans
OPTIMIZE TABLE) occurring during a request.Added new jobs for
rate_limit_hitsandlogin_attemptsbecause we weren't cleaning these up.