Load and save array properties as SET or JSON strings #160
+109
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take an example array of ['a', 'b'] In a SET column it will stored as 'a,b' In any other column type, it will be stored as a JSON string: '["a","b"]'
gwillz
approved these changes
Jan 14, 2026
Collaborator
gwillz
left a comment
gwillz
left a comment
There was a problem hiding this comment.
Very tight.
A few missing @param tags but they're on protected methods so I'm not too fussed.
| * @return void | ||
| * @throws JsonException | ||
| */ | ||
| public function update($config) |
Collaborator
There was a problem hiding this comment.
Would be good to chuck a @inheritdoc in here.
Actually we could start using the new #[\Override] attribute, which might communicate things even better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take an example array of ['a', 'b']
In a SET column it will stored as 'a,b'
In any other column type, it will be stored as a JSON string: '["a","b"]'