Skip to content

Conversation

therobbiedavis
Copy link
Collaborator

@therobbiedavis therobbiedavis commented Jul 25, 2025

Fixed

  • Fixed: Fixed an issue when the sidenav is collapsed on firefox.

@therobbiedavis therobbiedavis requested a review from Copilot July 25, 2025 18:43
Copilot

This comment was marked as outdated.

@Fesaa
Copy link
Member

Fesaa commented Jul 26, 2025

The side nav is still an issue for me, Firefox 141.0 Windows 11;
image

Epub image fix:

In scroll mode, the images are now pushes all the way to the left, as opposed to being centred and scrollable. I think it's fine if they're not scrollable, but they should be centred still I think

Now image
Before image

However, I haven't been able to test the actual fix as I don't have a file where it's currently broken.

@therobbiedavis therobbiedavis requested a review from Copilot July 26, 2025 21:49
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses two main bugs: fixing image scaling issues in the EPUB reader and resolving sidenav display problems specifically on Firefox browsers.

  • Improved image scaling in the EPUB reader by setting a maximum height constraint and adjusting CSS calculations
  • Fixed Firefox-specific sidenav width and text visibility issues when the navigation is collapsed
  • Updated CSS positioning and display properties for better book content layout

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
_sidenav.scss Increased collapsed sidenav width and added Firefox-specific text hiding for closed state
book-reader.component.ts Added image max height constant and updated CSS positioning logic for book content
book-reader.component.scss Modified image scaling calculations and added flex display properties for book content

@therobbiedavis
Copy link
Collaborator Author

The side nav is still an issue for me, Firefox 141.0 Windows 11; image

Epub image fix:

In scroll mode, the images are now pushes all the way to the left, as opposed to being centred and scrollable. I think it's fine if they're not scrollable, but they should be centred still I think
Now
Before

However, I haven't been able to test the actual fix as I don't have a file where it's currently broken.

@Fesaa I believe I have fixed both in the latest commit. The epub read needs a major shake out though. I am not too confident in how it handles images outside of the cover.

@therobbiedavis therobbiedavis marked this pull request as ready for review July 26, 2025 21:53
@majora2007
Copy link
Member

Can we split this so it's just the small side nav fix? The epub changes requires a lot of testing and will hold up this bugfix.

@therobbiedavis
Copy link
Collaborator Author

therobbiedavis commented Aug 2, 2025

Can we split this so it's just the small side nav fix? The epub changes requires a lot of testing and will hold up this bugfix.

@majora2007 I'll split it up tonight.

EDIT: Split

@therobbiedavis therobbiedavis added the UI Primarily UI impacting label Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Primarily UI impacting
Projects
Development

Successfully merging this pull request may close these issues.

3 participants