-
-
Notifications
You must be signed in to change notification settings - Fork 479
Bugfix/side nav issue #3955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Bugfix/side nav issue #3955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses two main bugs: fixing image scaling issues in the EPUB reader and resolving sidenav display problems specifically on Firefox browsers.
- Improved image scaling in the EPUB reader by setting a maximum height constraint and adjusting CSS calculations
- Fixed Firefox-specific sidenav width and text visibility issues when the navigation is collapsed
- Updated CSS positioning and display properties for better book content layout
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
_sidenav.scss | Increased collapsed sidenav width and added Firefox-specific text hiding for closed state |
book-reader.component.ts | Added image max height constant and updated CSS positioning logic for book content |
book-reader.component.scss | Modified image scaling calculations and added flex display properties for book content |
UI/Web/src/app/book-reader/_components/book-reader/book-reader.component.scss
Outdated
Show resolved
Hide resolved
UI/Web/src/app/book-reader/_components/book-reader/book-reader.component.scss
Outdated
Show resolved
Hide resolved
UI/Web/src/app/book-reader/_components/book-reader/book-reader.component.scss
Outdated
Show resolved
Hide resolved
@Fesaa I believe I have fixed both in the latest commit. The epub read needs a major shake out though. I am not too confident in how it handles images outside of the cover. |
….component.scss Co-authored-by: Copilot <[email protected]>
Can we split this so it's just the small side nav fix? The epub changes requires a lot of testing and will hold up this bugfix. |
@majora2007 I'll split it up tonight. EDIT: Split |
Fixed