Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Phaser-CE docset #5251

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Add Phaser-CE docset #5251

merged 4 commits into from
Dec 18, 2024

Conversation

ArtBIT
Copy link
Contributor

@ArtBIT ArtBIT commented Nov 28, 2024

Adding docset for Phaser - Community Edition https://github.com/phaserjs/phaser-ce

@github-actions GitHub Actions
Copy link
Contributor

Test result: PASS 🟢

Kapeli
Kapeli reviewed Dec 11, 2024
View reviewed changes
docsets/Phaser-CE/docset.json
{
"name": "Phaser-CE",
"version": "2.20.1",
"archive": "Phaser-CE.tgz",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't exist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I had to append the .txt to the actual file (Phaser-CE.tgz.txt), but omit the .txt here?

@Kapeli
Copy link
Owner

Kapeli commented Dec 11, 2024 •
edited
Loading

Please follow the format at https://github.com/Kapeli/Dash-User-Contributions/tree/master/Sample_Docset. The txt file is something my processing script leaves behind after pushing a new archive to the CDN.

@github-actions GitHub Actions
Copy link
Contributor

Test result: FAIL 🔴

Phaser-CE/Phaser-CE.tgz: FAIL ❌
Empty name found for row id "568" at "Phaser-CE.docset"
Empty name found for row id "569" at "Phaser-CE.docset"
Empty name found for row id "570" at "Phaser-CE.docset"

@github-actions GitHub Actions
Copy link
Contributor

Test result: FAIL 🔴

Phaser-CE/Phaser-CE.tgz: FAIL ❌
Empty name found for row id "568" at "Phaser-CE.docset"
Empty name found for row id "569" at "Phaser-CE.docset"
Empty name found for row id "570" at "Phaser-CE.docset"

@Kapeli
Copy link
Owner

Kapeli commented Dec 17, 2024

Failed validation: some entries in your docSet.dsidx have an empty name set.

@github-actions GitHub Actions
Copy link
Contributor

Test result: PASS 🟢

Phaser-CE/Phaser-CE.tgz: PASS ✅

@Kapeli Kapeli merged commit 1100cdb into Kapeli:master Dec 18, 2024
1 check passed
@Kapeli
Copy link
Owner

Kapeli commented Dec 18, 2024

Thank you!

Kapeli pushed a commit that referenced this pull request Dec 18, 2024
@ArtBIT
Add Phaser-CE docset (#5251)
a5947d3 
* Add Phaser-CE docset

* Rename .tgz.txt to .tgz

* Remove Defines
@ArtBIT
Copy link
Contributor Author

ArtBIT commented Dec 18, 2024

Thank you for your patience. All the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kapeli Kapeli Kapeli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArtBIT @Kapeli