-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UI): Add support for dark mode #2118
Conversation
45dd9b5
to
32c699d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2118 +/- ##
=========================================
Coverage 81.50% 81.50%
Complexity 456 456
=========================================
Files 522 523 +1
Lines 16716 16744 +28
Branches 3457 3492 +35
=========================================
+ Hits 13624 13648 +24
- Misses 2834 2838 +4
Partials 258 258 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
current test failure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
function App() { | ||
const ReloadProvider = useReload(); | ||
const controller = useMemo(() => ControllerService.createController(), []); | ||
const settingsAdapter = new LocalStorageSettingsAdapter(); | ||
let catalogUrl = CatalogSchemaLoader.DEFAULT_CATALOG_PATH; | ||
const settingsCatalogUrl = settingsAdapter.getSettings().catalogUrl; | ||
const colorSchema = settingsAdapter.getSettings().colorScheme; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit picking) typo, schema > schem"e"
I do not see a difference now despite eb1e19c : |
@apupier this is running locally |
retried and I have that now, I guess I have not recompiled correctly previously |
|
Context
This PR adds support for selecting light and dark modes in Kaoto. The mechanism works in 3 ways:
Screenshot
Normal
Selected
Source Code editor
VS Code
Todo
fix: #1543