feat: supporting multi dataset

[islxyqwe]

TODO: check all features working in multi dataset & single dataset.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
graphic-walker	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 22, 2024 9:45am

[github-actions]

Risk Level 3 - /home/runner/work/graphic-walker/graphic-walker/packages/graphic-walker/src/renderer/index.tsx

1. The useEffect hook at the end of the file has a dependency on isSpatial and vizStore, but these are not included in the dependency array. This could lead to unexpected behavior. Include isSpatial and vizStore in the dependency array of the useEffect hook.

useEffect(() => {
    // ... existing code ...
}, [isSpatial, vizStore]);

2. The handleGeomClick function is quite complex and could benefit from being broken down into smaller, more manageable functions. This would improve readability and maintainability of the code. Consider refactoring this function to simplify its logic.

---

Risk Level 3 - /home/runner/work/graphic-walker/graphic-walker/packages/graphic-walker/src/computation/clientComputation.ts

There is a potential issue with the filter case in the switch statement. The map function is used but the returned value is not used. This could lead to unexpected behavior. Consider removing the map function or use the returned value.

case 'filter': {
    res = await applyFilter(
        res,
        step.filters
            .filter(Boolean)
    );
    break;
}

---

Risk Level 3 - /home/runner/work/graphic-walker/graphic-walker/packages/graphic-walker/src/lib/insights/explainBySelection.ts

The explainBySelection function is quite large and complex. It could be broken down into smaller, more manageable functions to improve readability and maintainability. For example, the logic inside the for loop could be extracted into a separate function.

Also, the function is directly using the dataQuery function. This could make testing this function in isolation difficult. Consider passing the dataQuery function as a parameter to the explainBySelection function.

---

🔍🔄🧩

---

Powered by Code Review GPT