-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add request and response for code submissions #704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trizist
approved these changes
Feb 25, 2025
trizist
approved these changes
Feb 25, 2025
Subject: Re: [Kaggle/kaggle-api] Add request and response for code submissions (PR #704)
Looks good to me! I’ve reviewed the changes in PR #704 (view here) and I’m happy to approve it. Here’s my take:
Commit Summary: The addition of request/response handling for code submissions in 9eba3ab is a clear and valuable enhancement for the API.
File Changes:
kagglesdk/competitions/services/competition_api_service.py (14 lines): The service logic looks solid and aligns with existing patterns.
kagglesdk/competitions/types/competition_api_service.py (113 lines): The bulk of the update—types seem well-defined, though I’d suggest a quick docstring pass for clarity if not already done.
kagglesdk/models/types/model_api_service.py (16 lines) and model_enums.py (10 lines): Nice to see these tie in cleanly without overcomplicating things.
Patch: Skimmed the diff and it matches the summary—nothing unexpected.
Suggestions:
Consider adding a few unit tests for the new submit_code functionality (e.g., success and basic error cases) if time allows—I can help with that if needed.
A README example showing how to use this would be a cherry on top, but not a blocker.
No major issues spotted, and it’s ready to merge from my perspective. Great work on this feature—excited to see it in action! Approving now on GitHub.
Cheers,
Umair Abbas
Sent from Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Umair Siddiquie ***@***.***>
Sent: Tuesday, 25 February 2025 06:55:06
To: Kaggle/kaggle-api ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [Kaggle/kaggle-api] Add request and response for code submissions (PR #704)
@trizist approved this pull request.
—
Reply to this email directly, view it on GitHub<#704 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BGM7CBBHT27KEY2AOBF46J32RPEPVAVCNFSM6AAAAABXZGHRP6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMZYHEYTEOJUGA>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
jplotts
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From
kapigen
, at least thekagglesdk
part is.This was supposed to only have generated code but I accidentally included the "real" code, too.
There's a separate PR for the new handler, 33938.