Add more localization support, this time with lower_with_under
#2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably unnecessary
|
Yay it's back! :) |
|
What's the status of this? We really need to get this merged so that it doesn't keep conflicting every time we make loc updates to master. |
|
@TwistedGiraffe poke? |
|
Oh sorry NK, didn't see the reply earlier. |
|
That works! Just let's merge it immediately once you're done with that. :D |
|
@TwistedGiraffe any progress here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR currently adds localization support for:
Future additions include but are not limited to:
I will also change the
#rp0's into#rp1's in the source code. However, a complete localization of RP-1 GUI is probably best suited in another PR.As discussed in the last PR (#2154), this time the tags follow
lower_with_underand are all in a single file.