Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding cloudwatch target #227

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

karthik-kasarapu
Copy link

This will address the feature requested here

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #227 (8e7d9ae) into master (6867a4a) will increase coverage by 0.15%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   90.08%   90.24%   +0.15%     
==========================================
  Files          92       93       +1     
  Lines        6941     7051     +110     
==========================================
+ Hits         6253     6363     +110     
+ Misses        543      537       -6     
- Partials      145      151       +6     
Files Changed Coverage Δ
decoder/gauge.go 64.12% <100.00%> (+0.84%) ⬆️
decoder/graph.go 64.32% <100.00%> (+0.63%) ⬆️
decoder/heatmap.go 82.14% <100.00%> (+0.49%) ⬆️
decoder/singlestat.go 80.16% <100.00%> (+0.50%) ⬆️
decoder/stat.go 61.76% <100.00%> (+0.68%) ⬆️
decoder/table.go 81.25% <100.00%> (+1.25%) ⬆️
decoder/target.go 99.52% <100.00%> (+0.02%) ⬆️
decoder/timeseries.go 73.80% <100.00%> (+0.23%) ⬆️
gauge/gauge.go 100.00% <100.00%> (ø)
graph/graph.go 98.42% <100.00%> (+0.05%) ⬆️
... and 6 more

@karthik-kasarapu
Copy link
Author

I realized there's more work to be done to support cloudwatch target. I will this PR soon once the changes in my local are working as expected.

@karthik-kasarapu
Copy link
Author

This PR is ready for review.

@karthik-kasarapu
Copy link
Author

@K-Phoen Would really appreciate your feedback on this PR. Thank you.

@@ -6,6 +6,9 @@ import (
"github.com/K-Phoen/grabana/errors"
"github.com/K-Phoen/grabana/heatmap/axis"
"github.com/K-Phoen/grabana/links"

// "github.com/K-Phoen/grabana/target/cloudwatch"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fetchkarthikkasarapu perhaps this line here was left in the branch by accident?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@themarcelor good catch, removed that line.

@themarcelor
Copy link

@slimsag Just checking: Would you be able to take a look at this one? 🙏🏼

@lexfrei
Copy link

lexfrei commented Nov 13, 2023

Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants