adding cloudwatch target #227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #227 +/- ##
==========================================
+ Coverage 90.08% 90.24% +0.15%
==========================================
Files 92 93 +1
Lines 6941 7051 +110
==========================================
+ Hits 6253 6363 +110
+ Misses 543 537 -6
- Partials 145 151 +6
|
|
I realized there's more work to be done to support cloudwatch target. I will this PR soon once the changes in my local are working as expected. |
|
This PR is ready for review. |
|
@K-Phoen Would really appreciate your feedback on this PR. Thank you. |
themarcelor
reviewed
Sep 1, 2023
heatmap/heatmap.go
Outdated
| @@ -6,6 +6,9 @@ import ( | |||
| "github.com/K-Phoen/grabana/errors" | |||
| "github.com/K-Phoen/grabana/heatmap/axis" | |||
| "github.com/K-Phoen/grabana/links" | |||
|
|
|||
| // "github.com/K-Phoen/grabana/target/cloudwatch" | |||
There was a problem hiding this comment.
@fetchkarthikkasarapu perhaps this line here was left in the branch by accident?
There was a problem hiding this comment.
@themarcelor good catch, removed that line.
|
@slimsag Just checking: Would you be able to take a look at this one? 🙏🏼 |
|
Any news? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will address the feature requested here