Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gauge Converter #230

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Conversation

jlevesy
Copy link
Contributor

@jlevesy jlevesy commented Jul 31, 2023

What does this PR do?

Couple of tiny fixes for the JSON to YAML converter regarding gauges.

  • When the orientation from a gauge could not be determined, we tried to log a warning message, except that we logged the value from the StatPanel not the GaugePanel which is nil, causing a panic
  • auto is a value that might be returned from grafana. So instead of logging a warning, this PR makes the converter handles the auto value instead explicitely.

Hope this helps :)

@codecov-commenter
Copy link

Codecov Report

Merging #230 (85b1305) into master (339a3c5) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   40.99%   40.99%           
=======================================
  Files          39       39           
  Lines        2583     2583           
=======================================
  Hits         1059     1059           
  Misses       1484     1484           
  Partials       40       40           
Files Changed Coverage Δ
internal/pkg/converter/gauge.go 55.00% <50.00%> (ø)

@K-Phoen K-Phoen merged commit b376c74 into K-Phoen:master Oct 1, 2023
@jlevesy jlevesy deleted the jl/fix-json-converter branch October 27, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants