Develop with storybook #2882
Merged
Develop with storybook #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Google Maps Script can be loaded only once, load it in a global decorator for all components.
By resolving @react-google-maps/api from source, any changes made to source will reflect in storybook stories, both for core components and gatsby examples.
- Handle loading status - Use type script in config file to avoid invalid parameters - Update README
|
Hi @JustFly1984, this should be quick and easy to test. Let me know what do you think before I invest more time 😃 |
|
@mradenovic I will look into your PR this week. |
|
@mradenovic There is very minimal maintenance of storybook. I see that a lot of dependencies are not supporting react@17, hence will prevent us from easy react@18 support in the future, or require to dig into storybook itself, which could be an unpaid nightmare. |
|
I see what you mean. I checked the storybook repo and there is an issue about this which they are trying to resolve. I would keep it while it works. What would be the other workflow to hot reload components while you work on them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that Storybook was removed recently. When I checked the code and how it was implemented I understand why.
This approach should improve the following: