Skip to content

Conversation

Mudong-17
Copy link

No description provided.

Copy link

changeset-bot bot commented Apr 3, 2025

⚠️ No Changeset found

Latest commit: ea4e982

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Julien-R44
Copy link
Owner

Thanks a lot! I will need a bit of time to review it and see if we can improve things
Anyway thanks a lot, great feature to have!!

@Mudong-17
Copy link
Author

Thanks a lot! I will need a bit of time to review it and see if we can improve things Anyway thanks a lot, great feature to have!!

Thanks for the kind words! I’m glad you like the feature. Take your time with the review—I’d be happy to address any feedback or suggestions you might have to make it even better. Looking forward to hearing your thoughts!

@Julien-R44
Copy link
Owner

Julien-R44 commented Apr 20, 2025

Alright, took some time to go through the code and I'll be honest, it's a bit overwhelming. Not your fault, I know it's pretty tricky to get clean Drizzle integrations. I had looked at other packages ( like NextAuth, or Lucia If i remember well ) that provided Drizzle integrations and honestly felt the same way.

That’s actually why I didn’t include Drizzle from the start (on top of the fact that I don’t use it myself). So yeah, sorry about that but I’m gonna need a bit more time : I’d like to do some refactor to try and make things a bit cleaner so it will be easier for me to maintain long-term

@Mudong-17
Copy link
Author

I completely understand! Drizzle can be incredibly tricky. Your plan to refactor is smart. If you hit any snags, let’s troubleshoot together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants