Disallow additional path traversal patterns #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @tanmaykm |
DilumAluthge
force-pushed
the
dpa/path-traversal
branch
from
03f3258 to
814fa59
Compare
tanmaykm
reviewed
Jun 21, 2025
| @@ -187,10 +187,19 @@ struct Endpoint | |||
| query::Dict=Dict(), | |||
| allow_404::Bool=false, | |||
| ) | |||
| # do not allow path navigation in URLs | |||
| # Do not allow path navigation in URLs | |||
| # Disallowed pattern: .. | |||
| if occursin(r"\.\.", url) | |||
There was a problem hiding this comment.
I am not sure if this is needed any more... the specific path traversal cases it was needed for preventing seem to be covered in the below regex. Should this be removed?
There was a problem hiding this comment.
Hmmm. Technically the regex PATH_TRAVERSAL doesn't actually cover the pattern .. - is that okay?
There was a problem hiding this comment.
Ah I see that it does not cover r"^\.\.$", which is a valid path traversal without /. But that seems to be the only one, right? Should we then change it to that?
There was a problem hiding this comment.
But then, an Endpoint without / is not really valid. So it does seem okay to remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #50.
#50 disallowed some path navigation (specifically the pattern
..).In this PR, we also disallow some additional path traversal patterns (such as
./) that are not covered by #50.