Custom DFG errors #1147
Open
Custom DFG errors #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affie
force-pushed
the
enh/custom_label_error
branch
from
dd48d7e to
44659cf
Compare
Affie
commented
Jun 26, 2025
Affie
commented
Jun 26, 2025
Affie
commented
Jun 27, 2025
| @@ -0,0 +1,57 @@ | |||
| """ | |||
There was a problem hiding this comment.
@dehann , please have a look at the types and descriptions in this file, no need to review the rest.
There was a problem hiding this comment.
Ie. are you happy with names: LabelNotFoundError, LabelExistsError, and SerializationError
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1147 +/- ##
===========================================
- Coverage 73.58% 73.42% -0.17%
===========================================
Files 28 29 +1
Lines 2442 2457 +15
===========================================
+ Hits 1797 1804 +7
- Misses 645 653 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard errors and update functions that should throw them.