Update Compat Bounds for NNlib #185
Open
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed compat bounds - fixed broken environment for GPU tests
|
I'll note: although it looks like the CI tests for this are failing, I don't think that has anything to do with this PR. It would be great if a maintainer could look at the CI setup for this to figure out what the problem is, since its not something that I think I can resolve here |
davibarreira
reviewed
Jul 5, 2024
There was a problem hiding this comment.
@devmotion and @zsteve , this PR is just updating the version. I haven't worked on GPU stuff, so I haven't figured out why the error in the testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the compat bounds for NNlib to allow v0.9
I've also fixed an issue with the GPU tests where the test environment was erroring because it required an old version of CUDA and NNlibCUDA (which has been deprecated in favor of a CUDA extension in NNlib).
Please note: I have not been able to verify that the GPU tests run, since I do not have access to CUDA on my development machine.