Skip to content

Commit

Permalink
allow Nose-Hoover without units
Browse files Browse the repository at this point in the history
  • Loading branch information
jgreener64 committed Nov 17, 2023
1 parent 9bc0aa1 commit 130f18d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions docs/src/documentation.md
Original file line number Diff line number Diff line change
Expand Up @@ -340,10 +340,10 @@ Residue patches, virtual sites, file includes and any force types other than `Ha

Future work will increase the features and robustness when reading in structure files. In the mean time, the following tips may help you to read in a file correctly and without errors:

- Make sure there are no missing residues or heavy atoms. Tools such as [MODELLER](https://salilab.org/modeller) and [SCWRL4](http://dunbrack.fccc.edu/lab/scwrl) can fix these issues.
- Remove the hydrogen atoms and add them back [using OpenMM](http://docs.openmm.org/latest/userguide/application/03_model_building_editing.html#adding-hydrogens), which will ensure they have atom names compatible with the OpenMM force field files.
- Make sure that all residue names match the corresponding residue template name and that all atom names match the appropriate atom in the residue template.
- Non-standard residues also require `CONECT` records for Chemfiles to assign bonds correctly, see for example [a compatible alanine dipeptide file](https://github.com/noeblassel/SINEQSummerSchool2023/blob/main/notebooks/dipeptide_nowater.pdb).
* Make sure there are no missing residues or heavy atoms. Tools such as [MODELLER](https://salilab.org/modeller) and [SCWRL4](http://dunbrack.fccc.edu/lab/scwrl) can fix these issues.
* Remove the hydrogen atoms and add them back [using OpenMM](http://docs.openmm.org/latest/userguide/application/03_model_building_editing.html#adding-hydrogens), which will ensure they have atom names compatible with the OpenMM force field files.
* Make sure that all residue names match the corresponding residue template name and that all atom names match the appropriate atom in the residue template.
* Non-standard residues also require `CONECT` records for Chemfiles to assign bonds correctly, see for example [a compatible alanine dipeptide file](https://github.com/noeblassel/SINEQSummerSchool2023/blob/main/notebooks/dipeptide_nowater.pdb).

Some PDB files that read in fine can be found [here](https://github.com/greener-group/GB99dms/tree/main/structures/training/conf_1).

Expand Down
2 changes: 1 addition & 1 deletion src/simulators.jl
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ function simulate!(sys, sim::NoseHoover, n_steps::Integer;

zeta_half = zeta + (sim.dt / (2 * (sim.damping^2))) * ((temperature(sys) / sim.temperature) - 1)
KE_half = sum(masses(sys) .* sum.(abs2, v_half)) / 2
T_half = uconvert(u"K", 2 * KE_half / (df * sys.k))
T_half = uconvert(unit(sim.temperature), 2 * KE_half / (df * sys.k))
zeta = zeta_half + (sim.dt / (2 * (sim.damping^2))) * ((T_half / sim.temperature) - 1)

apply_constraints!(sys, old_coords, sim.dt)
Expand Down

0 comments on commit 130f18d

Please sign in to comment.