Cleanup Chi0Mixing docstrings and timings #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfherbst
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my tests employing LdosMixing for potential-mixing SCF iterations actually works way worse than with density-mixing, which surprises me a bit. My suspicion it's got to do with the fact that we actually apply ε rather than ε^\dagger during the linear solve, such that we cannot benefit from the implict low-pass filtering done by the Hartree kernel. Any thoughts @antoine-levitt ?
Edit: I'll split the LdosMixing changes to another PR (#587) to get the the other misc. changes into master.