Skip to content

Commit

Permalink
Bump minimal Julia version to 1.8 (#905)
Browse files Browse the repository at this point in the history
  • Loading branch information
mfherbst authored Nov 14, 2023
1 parent 4f3354b commit 4b86334
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v1
with:
version: '1.7'
version: '1.8'
arch: x64
- uses: julia-actions/cache@v1
- uses: julia-actions/julia-buildpkg@v1
Expand Down
11 changes: 5 additions & 6 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
stages:
- test

# This job tests DFTK.jl with Julia 1.8 on Noctua 2
# This job tests DFTK.jl with Julia 1.9 on Noctua 2
# It only runs when:
# - Commit in master
# - PR from branch with name ending in "gpu"
# - Manual run triggered
julia/1.8-n2:
julia/1.9-n2:
stage: test
variables:
# SCHEDULER_PARAMETERS: "-N 1 -n 1 -c 16 --gres=gpu:a100:1 --qos=devel -p dgx -t 00:15:00 -A hpc-prf-dftkjl"
SCHEDULER_PARAMETERS: "-N 1 -n 1 -c 16 --gres=gpu:a100:1 -p gpu -t 00:30:00 -A hpc-prf-dftkjl"
SCHEDULER_PARAMETERS: "-N 1 -n 1 -c 16 --gres=gpu:a100:1 --qos=devel -p dgx -t 00:30:00 -A hpc-prf-dftkjl"
JULIA_DEPOT_PATH: "/scratch/hpc-prf-dftkjl/dftkjl01/.julia-ci"
JULIA_NUM_THREADS: "1" # GPU and multi-threading not yet compatible
coverage: '/\(\d+.\d+\%\) covered/'
Expand All @@ -20,12 +19,12 @@ julia/1.8-n2:
- if: $CI_PIPELINE_SOURCE == "external_pull_request_event"
when: manual
script:
- module load lang/JuliaHPC/1.9.0-foss-2022a-CUDA-11.7.0
- module load lang/JuliaHPC/1.9.3-foss-2022a-CUDA-11.7.0
- julia --project=. -e '
using Pkg; Pkg.instantiate();
Pkg.add("CUDA");
using CUDA;
CUDA.set_runtime_version!(v"11.7")
CUDA.set_runtime_version!(v"11.7"; local_toolkit=true)
'
- julia --color=yes --project=. -e '
using Pkg;
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ Statistics = "1"
TimerOutputs = "0.5.12"
Unitful = "1"
UnitfulAtomic = "1"
julia = "1.7"
julia = "1.8"

[extras]
ASEconvert = "3da9722f-58c2-4165-81be-b4d7253e8fd2"
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ For getting started with DFTK, see [our documentation](https://docs.dftk.org):
- [Tutorial](https://docs.dftk.org/stable/guide/tutorial/)
- [Basic DFT examples](https://docs.dftk.org/stable/examples/metallic_systems/)

Note that at least **Julia 1.7** is required.
Note that at least **Julia 1.8** is required.

## Support and citation
DFTK is mostly developed as part of academic research.
Expand Down

0 comments on commit 4b86334

Please sign in to comment.