Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster safe_indices #334

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Faster safe_indices #334

merged 2 commits into from
Dec 16, 2023

Conversation

mateuszbaran
Copy link
Member

Resolves (3) from #333 .

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d38cc5) 99.65% compared to head (96bfe4c) 99.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #334   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          69       69           
  Lines        6337     6342    +5     
=======================================
+ Hits         6315     6320    +5     
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We could mark this as resolved in the corresponding issue (maybe with a symbol?) – and we should collect a few more before registering a new version for sure.

@mateuszbaran mateuszbaran merged commit 38f59b0 into master Dec 16, 2023
14 checks passed
@kellertuer kellertuer deleted the mbaran/faster-bfgs branch May 4, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants