Skip to content

Reuse last used compressor #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Reuse last used compressor #86

merged 2 commits into from
Feb 11, 2025

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Feb 9, 2025

Instead of allocating a new compressor for each entry that needs compression, try and reuse the last used compressor if it has the correct compression level.

This PR requires JuliaIO/CodecZlib.jl#97 to prevent memory leaks.

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (f955785) to head (8125e0f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files           6        6           
  Lines         803      803           
=======================================
  Hits          801      801           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nhz2 nhz2 marked this pull request as ready for review February 11, 2025 20:15
@nhz2 nhz2 merged commit 8e02836 into main Feb 11, 2025
22 checks passed
@nhz2 nhz2 deleted the reuse-compressor branch February 11, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant