Skip to content

Switch over to AK implementation for reductions #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Switch over to AK implementation for reductions #607

wants to merge 5 commits into from

Conversation

christiangnrd
Copy link
Member

@christiangnrd christiangnrd commented Jul 20, 2025 •
edited
Loading

AK's mapreduce is missing some features.

TODO:

  • Multiple dims specified
  • Multiple source arrays and map functions with multiple arguments.
    If we remove the ::AbstractArray annotations in the AK reduction functions, tweak use_KA_algo in AK, and define KA.get_backend(::Broadcast.Broadcasted{<backendcontainer>}) in each backend, the 1d function still errors when trying to convert the Broadcasted object to a view.

@christiangnrd christiangnrd mentioned this pull request Jul 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@christiangnrd