Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement to_vec for NamedTuple #100

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Implement to_vec for NamedTuple #100

merged 2 commits into from
Jul 17, 2020

Conversation

sethaxen
Copy link
Member

No description provided.

@sethaxen sethaxen requested a review from willtebbutt July 17, 2020 21:29
oxinabox
oxinabox approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do this, until we do #97

@sethaxen
Copy link
Member Author

Definitely.

This is part 1. Part 2 once this is merged is to add to_vec(::Composite{<:Any,<:NamedTuple}) to ChainRulesTestUtils, using this to_vec internally. This will let us use Composites with the testers, which should only get better once #97 is done.

@sethaxen sethaxen merged commit e129f10 into master Jul 17, 2020
@sethaxen sethaxen deleted the nttovec branch July 17, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxinabox oxinabox oxinabox approved these changes

@willtebbutt willtebbutt Awaiting requested review from willtebbutt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sethaxen @oxinabox