Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Julia 0.7 and 1.0 #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simonschoelly
Copy link

@simonschoelly simonschoelly commented Dec 23, 2018

Not sure how much this package is still maintained. But this pr should make it work with Julia 0.7 and 1.0 again.

@codecov-io
Copy link

codecov-io commented Dec 23, 2018

Codecov Report

Merging #13 into master will decrease coverage by 3.84%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage     100%   96.15%   -3.85%     
==========================================
  Files           1        1              
  Lines          53       52       -1     
==========================================
- Hits           53       50       -3     
- Misses          0        2       +2
Impacted Files Coverage Δ
src/StructsOfArrays.jl 96.15% <100%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 727925d...a79fe82. Read the comment docs.

@piever
Copy link

piever commented Apr 28, 2019

The same functionality of this packages is available on StructArrays which works on julia 1.0.

@simonschoelly
Copy link
Author

Yes, (I think we did discussed that on slack before), we should get StructOfArrays into JuliaArrays and deprecate this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants