Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QueryNode: handle invalid protobuf message decoding #5189

Merged
merged 1 commit into from
Sep 18, 2024
Merged

QueryNode: handle invalid protobuf message decoding #5189

merged 1 commit into from
Sep 18, 2024

Conversation

mnaamani
Copy link
Member

Solves processor failing with error

INFO: Processing block: 0009303780-14959, events count: 1
ERROR: Stopping the proccessor due to errors: {} name: Error, message: invalid wire type 4 at offset 1, stack: Error: invalid wire type 4 at offset 1
    at Reader.skipType (/joystream/metadata-protobuf/node_modules/protobufjs/src/reader.js:377:19)
    at Function.decode (/joystream/metadata-protobuf/compiled/index.js:8365:24)
    at content_ChannelOwnerRemarked (/joystream/query-node/mappings/lib/src/content/channel.js:158:63)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async MappingsLookupService.call (/joystream/node_modules/@joystream/hydra-processor/lib/executor/MappingsLookupService.js:80:9)
    at async /joystream/node_modules/@joystream/hydra-processor/lib/executor/TransactionalExecutor.js:41:17
INFO: Shutting down...

Fixed by used the deserializeMetadata helper method.

freakstatic
freakstatic approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@freakstatic freakstatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

query-node/mappings/src/content/channel.ts
): Promise<MetaprotocolTransactionSuccessful | MetaprotocolTxError> {
// if (!decodedMessage) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this commented code is probably not needed

kdembler
kdembler approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@kdembler kdembler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdembler kdembler merged commit e4f3204 into Joystream:master Sep 18, 2024
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdembler kdembler kdembler approved these changes

@freakstatic freakstatic freakstatic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnaamani @freakstatic @kdembler